Stream checker rule5 fix #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewimm
force-pushed
the
stream_checker_rule5_fix
branch
from
58d0b82 to
31b7024
Compare
bewimm
commented
Feb 28, 2022
| @@ -42,7 +42,7 @@ architecture a of tb_axi_stream_protocol_checker is | |||
| constant logger : logger_t := get_logger("protocol_checker"); | |||
| constant protocol_checker : axi_stream_protocol_checker_t := new_axi_stream_protocol_checker( | |||
| data_length => tdata'length, id_length => tid'length, dest_length => tdest'length, user_length => tuser'length, | |||
| logger => logger, actor => new_actor("protocol_checker"), max_waits => max_waits | |||
| logger => logger, actor => new_actor("protocol_checker"), max_waits => max_waits, allow_x_in_null_bytes => true | |||
There was a problem hiding this comment.
I'm not very happy with this solution.
I think it would be better to not mix the extension with the rest, but I'm not sure what the cleanest way of doing that is
LukasVik
reviewed
Apr 26, 2022
| logger : logger_t := axi_stream_logger; | ||
| actor : actor_t := null_actor; | ||
| max_waits : natural := 16; | ||
| allow_x_in_null_bytes : boolean := false |
There was a problem hiding this comment.
Align
Suggested change
| allow_x_in_null_bytes : boolean := false | |
| allow_x_in_null_bytes : boolean := false |
| begin | ||
| ret := data; | ||
| for i in keep'range loop | ||
| if keep(i) = '0' and strb(i) = '0' then |
There was a problem hiding this comment.
Per discussion in #798 this should perhaps be
Suggested change
| if keep(i) = '0' and strb(i) = '0' then | |
| if keep(i) = '0' or strb(i) = '0' then |
Null bytes must be ignored by the slave and the interconnect is allowed to remove these so checking that they contain valid data is not necessary.
This test checks that no errors are reported for tdata bytes that are masked by tkeep or tstrb if allow_x_in_non_data_bytes is set.
bewimm
force-pushed
the
stream_checker_rule5_fix
branch
from
31b7024 to
58c8888
Compare
|
See #997. |
Merged
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #798